The Forms group of the audit rail: what is wrong with the page's forms, and the tree edit that puts each one right.

Every finding carries the shape the rail already renders — node_id, group, severity, rule, message, detail — so a form check reads beside an accessibility one and its Fix button is the same button. What is different is that most of these have a mechanical answer: repair/3 hands back the ops that fix the document, and the few with no edit behind them say why rather than appearing to work.

What is asked of each node

Not asked here at all: MishkaCmsCore.Runtime.PageBuilder.Fields.form_node?/2 and MishkaCmsCore.Runtime.PageBuilder.Fields.field_node?/2 are the editor's one answer to both, so what the insert funnel treats as a form, what MishkaCmsCore.Runtime.PageBuilder.Containment refuses to nest, and what the audit reports on cannot disagree. This module used to carry its own copy of each, and so did the other two.

Two questions about a submit button, two answers

form-no-submit asks, per node and at any depth inside the form, whether anything sends it (Fields.submit_node?/3): a bare <button>, a kit button left to its default, the CMS's own <.button>. A button whose type is computed (Fields.type_unread?/3) may send it, so the rule stays quiet rather than offer a second Send button. submit-no-form asks the reverse about a button outside every form, and there only a written type="submit" or "image" counts (Fields.explicit_submit?/3), so a hero or dialog button stays quiet.

Why a wrap is an insert and a delete

MishkaCmsCore.Runtime.PageBuilder.Op's :wrap builds a bare tag with no attributes, and a form is nothing without its five. There is also no id to write them onto: the wrapper is minted inside the combinator. So the field's own source is re-parsed, wrapped and bound in one go by FormPlacement.wrap/3, inserted where the field stood, and the field deleted — two ops in one MishkaCmsCore.Runtime.PageBuilder.EditorSession.apply_ops/4 run, which is one undo step.

A Fix that cannot act says so

Two of these have no edit behind them, and each says why in a sentence the author reads instead of appearing to work: there is no form on the page to move a button into (submit-no-form); unwrapping this form would strand the fields inside it (form-in-form). repair/3 answers {:say, sentence} for those, which is not the same as :none — :none is a stale click, and the assistant is the right place for a document that has moved on. Everything else here has exactly one right answer and takes it.

A note for developers

form-no-destination is a :note, not counted against the page: a form nobody wrote code for still checks its fields and thanks the visitor. A form that names no submit event and posts to its own action has somewhere to go, so it raises nothing (receiver/2).

Its Fix finishes the form first, one edit per click: its name (as), then its source (for), then its submit event. A form with all three answers {:code, event, sentence}: the form's submit event, for the editor to open in the Code window, and the sentence to show someone who cannot write code.

See MishkaCmsCore.Runtime.PageBuilder.PageForms for what declares a form in the first place, and MishkaCmsCore.Runtime.PageBuilder.PageForms.Naming for the five names a seed derives.